Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert pk, pK, and pkill commands to the rzshell #3178

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Convert pk, pK, and pkill commands to the rzshell #3178

merged 1 commit into from
Nov 11, 2022

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Nov 11, 2022

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Convert pk command to rzshell
  • Convert pK command to rzshell
  • Convert pkill command to rzshell

Test plan

CI is green

Closing issues

Partially addresses #1590

@XVilka XVilka mentioned this pull request Nov 11, 2022
Open
32 tasks
@github-actions github-actions bot removed the RzIO label Nov 11, 2022
@XVilka XVilka merged commit 685035c into dev Nov 11, 2022
@XVilka XVilka deleted the asan-print-k-rzshell branch November 11, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XVilka @wargio