Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert po commands to the rzshell #3146

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Convert po commands to the rzshell #3146

merged 2 commits into from
Nov 8, 2022

Conversation

XVilka
Copy link
Member

@XVilka XVilka commented Oct 31, 2022

DO NOT SQUASH

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • Converted all po commands to rzshell without any addition or removal
  • Refactored rz_core_transform_op() and rz_core_write_block_op_at() to use size_t instead of int for buffer size (hexlen).

Test plan

CI is green

Closing issues

Partially addresses #1590

@XVilka XVilka added this to the 0.5.0 milestone Nov 3, 2022
@github-actions github-actions bot added the API label Nov 6, 2022
@wargio

This comment was marked as resolved.

@XVilka XVilka merged commit 004af00 into dev Nov 8, 2022
@XVilka XVilka deleted the asan-print-opcode-rzshell branch November 8, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants