`px` to rzshell #2853

imbillow · 2022-07-29T14:44:43Z

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
I've added tests that prove my fix is effective or that my feature works (if possible)
I've updated the rizin book with the relevant information (if needed)

Detailed description

3/n of #2813

pxd -> pxdw
pxd1 -> pxd
pxd2 -> pxdh
pxd4 -> pxdw
pxd8 -> pxdq
pxAv -> pxAl
pxt. -> removed ?
px/ -> keep
pxf -> TODO: not found old code ?

Test plan

...

Closing issues

...

- `pxd` -> `pxd 4` - `pxd<N> [len]` -> `pxd <N> [len]`

- `rz_core_print_cmp` - `rz_core_print_dump` - `rz_core_print_hexdump_` - `rz_core_print_hexdump_byline`

- test for `pxW` `pxH` - `void rz_print_section` -> `const char *rz_print_section`

Co-authored-by: Riccardo Schirone <[email protected]>

# Conflicts: # librz/core/cmd/cmd_print.c # librz/core/cprint.c # librz/include/rz_util/rz_print.h # librz/main/rz-find.c # librz/util/print.c

- `pxAv` -> `pxAl` - `pxt.` -> removed ? - `px/` -> keep - `pxf` -> TODO: not found old code ?

librz/core/cmd/cmd_print.c

ret2libc

Will review

librz/core/cprint.c

ret2libc · 2022-08-03T13:34:35Z

librz/include/rz_core.h

+RZ_API RZ_OWN char *rz_core_print_hexdump_diff_str(RZ_NONNULL RzCore *core, ut64 aa, ut64 ba, ut64 len);
+RZ_API RZ_OWN char *rz_core_print_dump_str(RZ_NONNULL RzCore *core, RzOutputMode mode, ut64 addr, ut8 n, int len, RzCorePrintFormatType format);
+RZ_API RZ_OWN char *rz_core_print_hexdump_or_hexdiff_str(RZ_NONNULL RzCore *core, RzOutputMode mode, ut64 addr, int len, bool use_comment);
+RZ_API RZ_OWN char *rz_core_print_hexdump_byline_str(RZ_NONNULL RzCore *core, bool hex_offset, ut64 addr, int len, ut8 size);
+


IIRC we said these functions should actually print and not be called _str (probably _print). Cutter or others can use internal functions like rz_print_hexdiff_str and similar, right?

@ret2libc if they print they should not be an API, if they should be an API they should return a string. Having an API returning nothing and just printing to the screen is absolutely useless from the user point of view.

I moved these to librz/core/core_private.h

@XVilka we use those kind of rzcore APIs in cases where we need to print the same things in different places (e.g. rz_core_asm_plugins_print). But yes, if we think it's not needed right now, let's not make them APIs.

imbillow and others added 30 commits July 25, 2022 15:13

convert px[ dDhHwWqQol] to new shell

ead507c

- `pxd` -> `pxd 4` - `pxd<N> [len]` -> `pxd <N> [len]`

fix

4a5da9e

fix

307b44a

fix

4842764

expose APIs

5dd8bff

- `rz_core_print_cmp` - `rz_core_print_dump` - `rz_core_print_hexdump_` - `rz_core_print_hexdump_byline`

remove old

d2380dc

fix

71d8dfe

fix

ae03930

fix

51043ce

fix

b4e0e23

fix

339c970

doxygen

c9129be

fix

d8d05d3

fix

cfe1eb4

- test for `pxW` `pxH` - `void rz_print_section` -> `const char *rz_print_section`

pxd -> pxd[ hwq]

a684dc6

char*

d059c9f

fix

a6e1114

unroll sb_print*

83baf1b

fix

53cdd52

fix

4beece1

dox

ee3db1a

notion

43e6fd0

Update librz/core/cmd_descs/cmd_print.yaml

def4f3f

Co-authored-by: Riccardo Schirone <[email protected]>

Update librz/core/cmd_descs/cmd_print.yaml

0e6548c

Co-authored-by: Riccardo Schirone <[email protected]>

Apply suggestions from code review

21f50c5

Co-authored-by: Riccardo Schirone <[email protected]>

Apply suggestions from code review

b99693b

Co-authored-by: Riccardo Schirone <[email protected]>

unroll macro

e6a9c76

revert style change

0290640

doxygen

e751299

fix

95b13c7

imbillow added 8 commits July 25, 2022 15:13

fix

ce80bb3

fix

7158457

fix

2346ca8

Merge branch 'expose_api_p' into rzshell_px

57db10b

# Conflicts: # librz/core/cmd/cmd_print.c # librz/core/cprint.c # librz/include/rz_util/rz_print.h # librz/main/rz-find.c # librz/util/print.c

fix

43bfb84

fix

071bbca

pxc

439a26d

port px to rzshell

ac48c7f

- `pxAv` -> `pxAl` - `pxt.` -> removed ? - `px/` -> keep - `pxf` -> TODO: not found old code ?

imbillow requested review from ret2libc, thestr4ng3r, wargio, XVilka and kazarmy as code owners July 29, 2022 14:44

github-actions bot added API rz-test RzCore RzUtil labels Jul 29, 2022

XVilka requested changes Jul 29, 2022

View reviewed changes

librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved

librz/core/cmd/cmd_print.c Outdated Show resolved Hide resolved

librz/core/cmd/cmd_print.c Show resolved Hide resolved

librz/core/cmd/cmd_print.c Show resolved Hide resolved

apply suggestions

e4ace76

XVilka approved these changes Jul 31, 2022

View reviewed changes

XVilka assigned ret2libc Jul 31, 2022

ret2libc requested changes Aug 3, 2022

View reviewed changes

ret2libc reviewed Aug 3, 2022

View reviewed changes

imbillow added 2 commits August 4, 2022 00:27

fix

b93cf62

Merge branch 'dev' into rzshell_px

a1bddeb

ret2libc approved these changes Aug 3, 2022

View reviewed changes

XVilka merged commit 0908b65 into dev Aug 4, 2022

XVilka deleted the rzshell_px branch August 4, 2022 01:11

XVilka mentioned this pull request Aug 4, 2022

Port p (print) to rzshell #1590

Open

32 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`px` to rzshell #2853

`px` to rzshell #2853

imbillow commented Jul 29, 2022 •

edited

Loading

ret2libc left a comment

ret2libc Aug 3, 2022

XVilka Aug 3, 2022

imbillow Aug 3, 2022

ret2libc Aug 3, 2022

px to rzshell #2853

px to rzshell #2853

Conversation

imbillow commented Jul 29, 2022 • edited Loading

ret2libc left a comment

Choose a reason for hiding this comment

ret2libc Aug 3, 2022

Choose a reason for hiding this comment

XVilka Aug 3, 2022

Choose a reason for hiding this comment

imbillow Aug 3, 2022

Choose a reason for hiding this comment

ret2libc Aug 3, 2022

Choose a reason for hiding this comment

`px` to rzshell #2853

`px` to rzshell #2853

imbillow commented Jul 29, 2022 •

edited

Loading