Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port command pa to new shell #2824

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Port command pa to new shell #2824

merged 4 commits into from
Jul 20, 2022

Conversation

PeiweiHu
Copy link
Contributor

@PeiweiHu PeiweiHu commented Jul 20, 2022 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

  • port pa/pad/pae/pade and pix to new shell
  • remove command paD
  • add some tests

Test plan

CI is green.

Closing issues

partially address #1590

ret2libc
ret2libc reviewed Jul 20, 2022
View reviewed changes
librz/core/cmd_descs/cmd_print.yaml Outdated Show resolved Hide resolved
librz/core/cmd_descs/cmd_print.yaml Outdated Show resolved Hide resolved
librz/core/cmd/cmd_print.c Show resolved Hide resolved
librz/core/cmd/cmd_print.c
RZ_IPI RzCmdStatus rz_hex_of_assembly_handler(RzCore *core, int argc, const char **argv, RzOutputMode mode) {
char *buf = rz_core_hex_of_assembly(core, argv[1]);
if (!buf) {
return RZ_CMD_STATUS_ERROR;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please print an error message as well. Here and in the other commands. These are useful to users so they get some feedback if things go wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rz_core_hex_of_assembly will output the error message when buf == NULL . The user can get feedback. The same goes for other commands.

librz/include/rz_core.h Outdated Show resolved Hide resolved
librz/core/cprint.c Outdated Show resolved Hide resolved
@XVilka XVilka requested a review from ret2libc July 20, 2022 13:20
@XVilka XVilka mentioned this pull request Jul 20, 2022
Open
32 tasks
@ret2libc ret2libc enabled auto-merge (squash) July 20, 2022 17:31
@ret2libc ret2libc merged commit 7001e81 into rizinorg:dev Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ret2libc ret2libc ret2libc approved these changes

@XVilka XVilka XVilka approved these changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

Assignees
No one assigned
Labels
API rz-test RzCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeiweiHu @XVilka @ret2libc