Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec to use latest doc workflow from docs-spec-template #168

Merged
merged 1 commit into from
May 24, 2024

Conversation

kbroch-rivosinc
Copy link
Contributor

relates to #167

wmat
wmat previously approved these changes May 23, 2024
Copy link

@wmat wmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmat wmat dismissed their stale review May 24, 2024 15:01

Create Spec Document action fails.

@wmat
Copy link

wmat commented May 24, 2024

Hi @kbroch-rivosinc looking at this again, I noticed that the Create Spec Document fails. The initial check was successful but did not upload any artifacts as it failed to find them. I manually ran it again and it failed there as well. Seems to be a src directory problem.

@kbroch-rivosinc
Copy link
Contributor Author

Hi @kbroch-rivosinc looking at this again, I noticed that the Create Spec Document fails. The initial check was successful but did not upload any artifacts as it failed to find them. I manually ran it again and it failed there as well. Seems to be a src directory problem.

Thx for catching. I forgot to update the GH actions. I'll add that.

@kbroch-rivosinc kbroch-rivosinc force-pushed the dev/kbroch/sync-doc-spec-template branch from 6edc270 to 9cbc67a Compare May 24, 2024 17:37
@kbroch-rivosinc kbroch-rivosinc requested a review from wmat May 24, 2024 17:53
@wmat
Copy link

wmat commented May 24, 2024

Thanks for fixing.

Copy link

@wmat wmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kbroch-rivosinc kbroch-rivosinc merged commit a3a9463 into main May 24, 2024
2 checks passed
@kbroch-rivosinc kbroch-rivosinc deleted the dev/kbroch/sync-doc-spec-template branch May 24, 2024 18:28
@kasperk81
Copy link

moving location of documents (especially rva23), which are linked by several dozen sources out in the wild should be subjected to little bit of scrutiny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants