Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve conflicts between PR #152 and branch master #211

Merged

Conversation

dragon540
Copy link
Collaborator

No description provided.

@dragon540 dragon540 marked this pull request as ready for review September 27, 2024 12:42
@dragon540 dragon540 marked this pull request as draft September 27, 2024 12:43
@klingaard
Copy link
Collaborator

🤔 Shobhit, how did you do the merge? There shouldn't be this many files changed...

@dragon540
Copy link
Collaborator Author

dragon540 commented Sep 29, 2024

@klingaard, I have mistakenly committed .idea and cmake-build-debug too, removing them should decrease the number of files changed to ~40 files. To do the merge, I copied the branch on PR #152 under my name, and merged master branch into it after resolving conflicts.

Copy link
Collaborator

@jeffnye-gh jeffnye-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the clion (.idea etc) and .cmake files from this PR and push again
also the cmake-build-debug/CMakeCache.txt cache files should not be part of the PR. I assume these are also part of clion.

you should consider adding these files to the toplevel .gitignore for future

@dragon540
Copy link
Collaborator Author

removed extra files and folders (.idea, cmake-build-debug, etc) from the PR

@dragon540 dragon540 marked this pull request as ready for review October 19, 2024 12:06
Copy link
Collaborator

@jeffnye-gh jeffnye-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes requested, remove some generated files.

@@ -0,0 +1,3 @@
Start testing: Sep 23 23:54 IST
----------------------------------------------------------
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated collateral, i dont think it should be in the commit list.

@@ -0,0 +1,3 @@
Start testing: Sep 23 23:54 IST
----------------------------------------------------------
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also generated, I don't see a reason to commit it.

@dragon540
Copy link
Collaborator Author

Removed generated log files

@dragon540 dragon540 changed the title Resolve conflicts between danbone/issue_143_icache on PR #152 and branch master Resolve conflicts between PR #152 and branch master Oct 27, 2024
stf_lib Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to update stflib?

Copy link
Collaborator

@klingaard klingaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good work. Before merging, I'd like to make sure moving stflib was intended.

@dragon540
Copy link
Collaborator Author

I was facing some issues with the version of stflib which was there in dan's PR, therefore updated it. However, the version of stflib which is in upstream branch works too. I have updated the stflib submodule to keep it consistent with the present version in olympia.

@klingaard klingaard merged commit 8f9e442 into riscv-software-src:master Oct 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants