Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use protobufjs.loadSync to ensure schema load timing. #41

Merged
merged 1 commit into from
May 3, 2021

Conversation

perezd
Copy link
Member

@perezd perezd commented May 3, 2021

I think this would address #35, @smarigowda, do you have a test environment you can verify this patch with?

@jamtur01
Copy link
Member

jamtur01 commented May 3, 2021

Okay - I've just tested it. Works for me.

@jamtur01 jamtur01 requested review from jamtur01 and removed request for jamtur01 May 3, 2021 21:16
@jamtur01
Copy link
Member

jamtur01 commented May 3, 2021

@perezd Do we want to replace __dirname and fix #37 too?

@perezd
Copy link
Member Author

perezd commented May 3, 2021

I'm not really sure what else it should be, any suggested alternatives?

@perezd
Copy link
Member Author

perezd commented May 3, 2021

Also honestly, I'm not convinced __dirname is an anti-pattern truly in commonjs, so let's merge this and let discussion continue on #37 if alternatives can/should be explored.

@perezd perezd merged commit aa4e3c8 into master May 3, 2021
@perezd perezd deleted the perezd-patch-1 branch May 3, 2021 22:43
@jamtur01
Copy link
Member

jamtur01 commented May 3, 2021

Sounds good to me

@smarigowda
Copy link

I think this would address #35, @smarigowda, do you have a test environment you can verify this patch with?

I tested this on my local setup and it is working. I am able to see the event in Riemann log. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants