Fix build for newer versions of Rhai. #10
schungxAnnotations
13 warnings
|
missing documentation for a function:
src/url.rs#L258
warning: missing documentation for a function
--> src/url.rs:258:5
|
258 | / pub fn query_append(url: &mut Url, key: &str, value: &str) {
259 | | url.query_pairs_mut().append_pair(key, value);
260 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
|
|
length comparison to zero:
src/url.rs#L251
warning: length comparison to zero
--> src/url.rs:251:16
|
251 | if q.len() == 0 {
| ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `q.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
length comparison to zero:
src/url.rs#L185
warning: length comparison to zero
--> src/url.rs:185:12
|
185 | if value.len() > 0 {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
length comparison to zero:
src/url.rs#L153
warning: length comparison to zero
--> src/url.rs:153:12
|
153 | if value.len() > 0 {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
length comparison to zero:
src/url.rs#L121
warning: length comparison to zero
--> src/url.rs:121:12
|
121 | if value.len() > 0 {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
|
missing documentation for a module:
src/lib.rs#L16
warning: missing documentation for a module
--> src/lib.rs:16:1
|
16 | pub(crate) mod url;
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_docs_in_private_items
note: the lint level is defined here
--> src/lib.rs:2:9
|
2 | #![warn(clippy::missing_docs_in_private_items)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
length comparison to zero:
src/url.rs#L251
warning: length comparison to zero
--> src/url.rs:251:16
|
251 | if q.len() == 0 {
| ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `q.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
length comparison to zero:
src/url.rs#L185
warning: length comparison to zero
--> src/url.rs:185:12
|
185 | if value.len() > 0 {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
length comparison to zero:
src/url.rs#L153
warning: length comparison to zero
--> src/url.rs:153:12
|
153 | if value.len() > 0 {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
|
|
length comparison to zero:
src/url.rs#L121
warning: length comparison to zero
--> src/url.rs:121:12
|
121 | if value.len() > 0 {
| ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!value.is_empty()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
= note: `#[warn(clippy::len_zero)]` on by default
|
|
this `if` statement can be collapsed:
build.rs#L164
warning: this `if` statement can be collapsed
--> build.rs:164:17
|
164 | / if idx != 0 && idx < function_list.len() - 1 {
165 | | if name == function_list[idx - 1].name && name != function_list[idx + 1].name {
166 | | indented = false;
167 | | }
168 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
help: collapse nested if block
|
164 ~ if idx != 0 && idx < function_list.len() - 1 && name == function_list[idx - 1].name && name != function_list[idx + 1].name {
165 + indented = false;
166 + }
|
|
|
this `if` statement can be collapsed:
build.rs#L146
warning: this `if` statement can be collapsed
--> build.rs:146:17
|
146 | / if idx < function_list.len() - 1 {
147 | | if name == function_list[idx + 1].name && !indented {
148 | | writeln!(writer, "## {prefix}`{}`", name.to_owned())
149 | | .expect("Cannot write to {doc_file}");
150 | | indented = true;
151 | | }
152 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `#[warn(clippy::collapsible_if)]` on by default
help: collapse nested if block
|
146 ~ if idx < function_list.len() - 1 && name == function_list[idx + 1].name && !indented {
147 + writeln!(writer, "## {prefix}`{}`", name.to_owned())
148 + .expect("Cannot write to {doc_file}");
149 + indented = true;
150 + }
|
|
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|