Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run snapshot tests everywhere but render/compare only on mac #8252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Nov 29, 2024

Related

What

Run snapshot tests everywhere but render/compare only on mac

@abey79 abey79 added 🔨 testing testing and benchmarks exclude from changelog PRs with this won't show up in CHANGELOG.md labels Nov 29, 2024
Copy link

github-actions bot commented Nov 29, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link
243d699 https://rerun.io/viewer/pr/8252

Note: This comment is updated whenever you push a commit.

@abey79
Copy link
Member Author

abey79 commented Nov 29, 2024

@rerun-bot full-test

@nikolausWest
Copy link
Member

What is the workflow then for generating a new snapshot if you're not on Mac? Is it run CI, manually download the right artifact, check it in, push, run CI again?

@abey79
Copy link
Member Author

abey79 commented Nov 29, 2024

What is the workflow then for generating a new snapshot if you're not on Mac? Is it run CI, manually download the right artifact, check it in, push, run CI again?

Well I'm not sure we can even recover the artefact from CI now, we'd need to add that. You could generate a reference snapshot locally by temporarily removing the mac-only flag. The snapshot will likely have slight differences, but I believe the comparison allows for that.

Anyways, all of this is very painful, so we basically need #8245. I'm adding it to next cycle, chances are we can sort it out in a time-boxed pairing session with @Wumpf.

@lucasmerlin
Copy link
Contributor

Well I'm not sure we can even recover the artefact from CI now, we'd need to add that.

Should be quite simple to add this:
https://github.com/emilk/egui/blob/master/.github/workflows/rust.yml#L247-L253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants