Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix spelling issues #18

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

docs: fix spelling issues #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
312767f
Update downloading_artifacts.md
nnsW3 Sep 19, 2024
530b3d8
Update AnyCodable.swift
nnsW3 Sep 19, 2024
d3b9aca
Update AppKitClient.swift
nnsW3 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Commons/AnyCodable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public struct AnyCodable {
}

/**
Returns the underlying value, provided it matches the type spcified.
Returns the underlying value, provided it matches the type specified.

Use this method to retrieve a strong-typed value, as long as it can be decoded from its underlying representation.

Expand Down
10 changes: 5 additions & 5 deletions Sources/ReownAppKit/Core/AppKitClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,28 @@ public class AppKitClient {

/// Publisher that sends sessions on every sessions update
///
/// Event will be emited on controller and non-controller clients.
/// Event will be emitted on controller and non-controller clients.
public var sessionsPublisher: AnyPublisher<[Session], Never> {
signClient.sessionsPublisher.eraseToAnyPublisher()
}

/// Publisher that sends session when one is settled
///
/// Event is emited on proposer and responder client when both communicating peers have successfully established a session.
/// Event is emitted on proposer and responder client when both communicating peers have successfully established a session.
public var sessionSettlePublisher: AnyPublisher<Session, Never> {
signClient.sessionSettlePublisher.eraseToAnyPublisher()
}

/// Publisher that sends session proposal that has been rejected
///
/// Event will be emited on dApp client only.
/// Event will be emitted on dApp client only.
public var sessionRejectionPublisher: AnyPublisher<(Session.Proposal, Reason), Never> {
signClient.sessionRejectionPublisher.eraseToAnyPublisher()
}

/// Publisher that sends deleted session topic
///
/// Event can be emited on any type of the client.
/// Event can be emitted on any type of the client.
public var sessionDeletePublisher: AnyPublisher<(String, Reason), Never> {
signClient.sessionDeletePublisher.eraseToAnyPublisher()
}
Expand Down Expand Up @@ -67,7 +67,7 @@ public class AppKitClient {

/// Publisher that sends session event
///
/// Event will be emited on dApp client only
/// Event will be emitted on dApp client only
public var sessionEventPublisher: AnyPublisher<(event: Session.Event, sessionTopic: String, chainId: Blockchain?), Never> {
signClient.sessionEventPublisher.eraseToAnyPublisher()
}
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/downloading_artifacts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ This will return list of artifacts in following format
...
]
```
Once you find the artifact you are interested in, you really need only `id` and/or `archive_download_url` fields from it, as they are necessary for next step which is dowloading the artifact
Once you find the artifact you are interested in, you really need only `id` and/or `archive_download_url` fields from it, as they are necessary for next step which is downloading the artifact

You can learn more at https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28#list-artifacts-for-a-repository

Expand All @@ -72,4 +72,4 @@ Using either `id` from previous step as ARTIFACT_ID or path part from `archive_d

Usually you will end up with something like this -> `/repos/WalletConnect/WalletConnectSwiftV2/actions/artifacts/721939868/zip > cool_artifact.zip`

You can learn more at https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28#download-an-artifact
You can learn more at https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28#download-an-artifact