Add CPU usage plugin #437
Merged
Add CPU usage plugin #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge this into a separate branch for now, I want to check if it's better to report negative numbers or |
lbulej
merged commit 73302d2
into
renaissance-benchmarks:plugin/jmx-cpu
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the request in post #238, I added a plugin that exports CPU metrics. Unfortunately, I ran into a problem with inconsistent measurements. The
OperatingSystemMXBeanmodule, which is used to gather the metrics, can returnNaNvalues if the CPU load cannot be read at that moment. This produces a0values in the measurement results.Also, not all devices provide the
OperatingSystemMXBeansubinterface of thecom.sun.managementpackage, so some metrics are not available in some OSes.