Update primary dependencies in db-shootout benchmark to improve JVM compatibility #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drops the jcl-over-slf4j version override and instead adds an override for slf4j-api version.
Updates MapDB version from 3.0.1 to 3.0.10 Updates H2 MVStore from version 1.4.192 to version 2.1.214 Updates Chronicle Map from version 3.17.0 to version 3.22.9 The db-shootout now supports JVM version from 8 to 18 instead of 8 to 11. JVM 19 is not supported because chronicle-core uses reflection to look up the sun.nio.ch.FileChannelImpl.map0(int,long,long,boolean) method which is no longer present in JDK19. SBT fails to find third-party-bom for more recent Chronicle Map versions.
vhotspur
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates MapDB version from 3.0.1 to 3.0.10, H2 MVStore from version 1.4.192 to version 2.1.214, and Chronicle Map from version 3.17.0 to version 3.22.9
This makes the
db-shootoutbenchmark compatible with JDK 18 (up from 11).Starting with JDK 19, the benchmark fails because
chronicle-coreis using reflection to look up thesun.nio.ch.FileChannelImpl.map0(int,long,long,boolean)method which is not available in JDK 19 anymore.Using more recent Chronicle Map (such as 3.23.5 or even 3.24ea3) is currently not an option, because SBT fails to find their
third-party-bom.