Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement getItemURL for Dropbox #1130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement getItemURL for Dropbox #1130

wants to merge 3 commits into from

Commits on Feb 14, 2019

  1. Make BaseClient#getItemURL async

    @Ragnis
    Ragnis committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    cb65deb View commit details
    Browse the repository at this point in the history

  2. Re-implement Dropbox#getItemURL

    @Ragnis
    Ragnis committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    a008622 View commit details
    Browse the repository at this point in the history

  3. Remove an old test 

    The test assumes that if a file is successfully fetched from a /public/
directory then the download URL can also be used as a public URL. That
is however not true since DropBox requires all public URLs to be
explicitly created.
    @Ragnis
    Ragnis committed Feb 14, 2019
    Configuration menu
    Copy the full SHA
    26be9bf View commit details
    Browse the repository at this point in the history