Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination #24

Merged
merged 7 commits into from
May 4, 2019
Merged

Fix pagination #24

merged 7 commits into from
May 4, 2019

Conversation

jeremysuriel
Copy link
Contributor

Fix pagination

Refs #21

@pavelbinar pavelbinar changed the base branch from master to develop May 4, 2019 10:50
@pavelbinar
Copy link
Member

@jeremysuriel Excellent, could you please update the tests so we don't have failing CI?

@codecov
Copy link

codecov bot commented May 4, 2019

Codecov Report

Merging #24 into develop will increase coverage by 2.7%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #24     +/-   ##
==========================================
+ Coverage    49.01%   51.72%   +2.7%     
==========================================
  Files            1        1             
  Lines          102      116     +14     
  Branches        19       23      +4     
==========================================
+ Hits            50       60     +10     
- Misses          52       56      +4
Impacted Files Coverage Δ
app.js 51.72% <75%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9b879...69b8479. Read the comment docs.

@pavelbinar pavelbinar merged commit 8299b6d into remoteorigin:develop May 4, 2019
@pavelbinar
Copy link
Member

All right, here we go 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants