Fix parsing of the is_master attribute in the URL #3367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixed the parsing of the is_master attribute in the Redis URL.
When the Redis URL is 'redis://redis-master/1?is_master=0', it is supposed to find the slave node of redis-master for read operations. However, since is_master was parsed as '0' and not correctly interpreted as False, it failed to use the slave node.
I encountered this issue when trying to implement read-write separation using SentinelConnectionPool.