Beakerlib tests adjustments #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacikpa
changed the title
zacikpa
force-pushed
the
fix-variable-support-test
branch
from
0fe2ab9
to
609f2a4
Compare
yarda
approved these changes
Jul 23, 2024
| @@ -24,7 +24,7 @@ rlJournalStart | |||
| rlPhaseStartSetup | |||
| rlAssertRpm $PACKAGE | |||
| rlImport "tuned/basic" | |||
| rlRun "tunedDisableSystemdRateLimitingStart" | |||
| tunedDisableSystemdRateLimitingStart | |||
There was a problem hiding this comment.
I think all commands (including functions) should be started through rlRun, so it's easy to spot possible test problems in a consistent way. But I will let it on @RHEmployee to eventually make such changes. For now, I think it's good to be consistent, thus let's go with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor test adjustments:
tunedDisableSystemdRateLimitingStartwithoutrlRun, so stick to it invariables-support-in-profiles, too.rlServiceRestoreto theerror-messagestest. This fixes recent test failures in Rawhide, most likely triggered by the recent addition of TuneD to systemd presets.