hotplug: wait for device initialization #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarda
force-pushed
the
hotplug_dev_init_wait
branch
from
4d5bdd8
to
e93c17c
Compare
zacikpa
reviewed
Jul 23, 2024
tuned/hardware/inventory.py
Outdated
| @@ -54,6 +54,14 @@ def _handle_udev_event(self, event, device): | |||
| if not device.subsystem in self._subscriptions: | |||
| return | |||
|
|
|||
| retry = consts.HOTPLUG_WAIT_FOR_DEV_INIT_RETRIES | |||
| while not device.is_initialized and retry > 0: | |||
| log.debug("Device '%s' is uninitialized, waiting '%d' seconds for its initialization." % (device, consts.HOTPLUG_WAIT_FOR_DEV_INIT_DELAY)) | |||
There was a problem hiding this comment.
Maybe print this as float, the current log would just say 0 seconds in the default configuration.
Suggested change
| log.debug("Device '%s' is uninitialized, waiting '%d' seconds for its initialization." % (device, consts.HOTPLUG_WAIT_FOR_DEV_INIT_DELAY)) | |
| log.debug("Device '%s' is uninitialized, waiting '%.2f' seconds for its initialization." % (device, consts.HOTPLUG_WAIT_FOR_DEV_INIT_DELAY)) |
Resolves: RHEL-39468 Signed-off-by: Jaroslav Škarvada <[email protected]>
yarda
force-pushed
the
hotplug_dev_init_wait
branch
from
e93c17c
to
27349f8
Compare
zacikpa
approved these changes
Jul 23, 2024
|
Centos 7 CI failure is caused by dropped EPEL-7, it's being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first shot trying to resolve the potential problem with hotplug. It needs thorough testing. I am not sure whether it's a good thing to use it also for the remove events, maybe it would require refactor.