Handle different units in results. #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdvalin
requested changes
Nov 19, 2024
Comment on lines
+259
to
+283
| convert_unit() | ||
| { | ||
| unit=$1 | ||
| base=1 | ||
|
|
||
| if [[ $unit == "KiB/s" ]]; then | ||
| base=1024 | ||
| elif [[ $unit == "MiB/s" ]]; then | ||
| base=`echo 1024*1024 |bc` | ||
| elif [[ $unit == "GiB/s" ]]; then | ||
| base=`echo 1024*1024*1024 |bc` | ||
| elif [[ $unit == "sec" ]]; then | ||
| base=`echo 1000*1000*1000 | bc` | ||
| elif [[ $unit == "msec" ]]; then | ||
| base=`echo 1000*1000 | bc` | ||
| elif [[ $unit == "usec" ]]; then | ||
| base=1000 | ||
| elif [[ $unit == "nsec" ]]; then | ||
| base=1 | ||
| else | ||
| echo unknown unit $unit | ||
| exit 1 | ||
| fi | ||
| echo $base | ||
| } |
There was a problem hiding this comment.
As stated in pyperf wrapper, why duplicate the unit conversion across multiple wrappers?
Comment on lines
+265
to
+269
| base=1024 | ||
| elif [[ $unit == "MiB/s" ]]; then | ||
| base=`echo 1024*1024 |bc` | ||
| elif [[ $unit == "GiB/s" ]]; then | ||
| base=`echo 1024*1024*1024 |bc` |
There was a problem hiding this comment.
Maybe to make this more readable, you can express KiB/s as 2^10, MiB/s as 2^20, etc.
Comment on lines
+270
to
+277
| elif [[ $unit == "sec" ]]; then | ||
| base=`echo 1000*1000*1000 | bc` | ||
| elif [[ $unit == "msec" ]]; then | ||
| base=`echo 1000*1000 | bc` | ||
| elif [[ $unit == "usec" ]]; then | ||
| base=1000 | ||
| elif [[ $unit == "nsec" ]]; then | ||
| base=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle different units in results
Output csv file with individual process results.