Resolve merge conflicts #490
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkatsevych please take a look fyi @ltlaitoff |
bkatsevych
reviewed
Nov 6, 2023
bkatsevych
approved these changes
Nov 6, 2023
|
@bkatsevych should i create a new PR with current changes onto the last sync PR? The problem is that after the last sync update the analyze_bundle check is not passing anyway |
|
@alinkedd Go for it |
|
Close in favor of #494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done:
After merging this PR or cherry picking related commit onto #489, we will be able to: