Cleanup and docs

reactiveui · Jun 20, 2018 · c2e3678 · c2e3678
1 parent bc81dd1
commit c2e3678
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/Directory.build.props b/Directory.build.props
@@ -7,7 +7,6 @@
     <PackageProjectUrl>https://github.com/reactiveui/refit</PackageProjectUrl>
     <PackageLicenseUrl>https://github.com/reactiveui/refit/blob/master/COPYING</PackageLicenseUrl>
     <DefaultLanguage>en-US</DefaultLanguage>
-    <IncludeSymbols>false</IncludeSymbols>
     <IsTestProject>$(MSBuildProjectName.Contains('Test'))</IsTestProject>
     <Description>The automatic type-safe REST library for Xamarin and .NET</Description>
     <NoWarn>$(NoWarn);1701;1702;CS1591;NU1701</NoWarn>

diff --git a/Refit.HttpClientFactory/HttpClientFactoryExtensions.cs b/Refit.HttpClientFactory/HttpClientFactoryExtensions.cs
@@ -4,6 +4,13 @@ namespace Refit
 {
     public static class HttpClientFactoryExtensions
     {
+        /// <summary>
+        /// Adds a Refit client to the DI container
+        /// </summary>
+        /// <typeparam name="T">Type of the Refit interface</typeparam>
+        /// <param name="services">container</param>
+        /// <param name="settings">Optional. Settings to configure the instance with</param>
+        /// <returns></returns>
         public static IHttpClientBuilder AddRefitClient<T>(this IServiceCollection services, RefitSettings settings = null) where T : class
         {
             services.AddSingleton(provider => RequestBuilder.ForType<T>(settings));

diff --git a/Refit.Tests/RequestBuilder.cs b/Refit.Tests/RequestBuilder.cs
@@ -630,7 +630,7 @@ public void HttpContentAsApiResponseTest()
             Assert.NotNull(task.Result.Headers);
             Assert.True(task.Result.IsSuccessStatusCode);
             Assert.NotNull(task.Result.ReasonPhrase);
-            Assert.False(task.Result.StatusCode == default(HttpStatusCode));
+            Assert.False(task.Result.StatusCode == default);
             Assert.NotNull(task.Result.Version);
 
             Assert.Equal(testHttpMessageHandler.RequestMessage.Content, mpc);
@@ -676,7 +676,7 @@ public void StreamResponseAsApiResponseTest()
             Assert.NotNull(task.Result.Headers);
             Assert.True(task.Result.IsSuccessStatusCode);
             Assert.NotNull(task.Result.ReasonPhrase);
-            Assert.False(task.Result.StatusCode == default(HttpStatusCode));
+            Assert.False(task.Result.StatusCode == default);
             Assert.NotNull(task.Result.Version);
 
             using (var reader = new StreamReader(task.Result.Content))
@@ -918,7 +918,7 @@ public void ReadStringContentWithMetadata()
             Assert.NotNull(task.Result.Headers);
             Assert.True(task.Result.IsSuccessStatusCode);
             Assert.NotNull(task.Result.ReasonPhrase);
-            Assert.False(task.Result.StatusCode == default(HttpStatusCode));
+            Assert.False(task.Result.StatusCode == default);
             Assert.NotNull(task.Result.Version);
 
             Assert.Equal("test", task.Result.Content);

diff --git a/Refit.Tests/RestService.cs b/Refit.Tests/RestService.cs
@@ -263,7 +263,7 @@ public async Task HitTheGitHubUserApiAsApiResponse()
             Assert.True(result.IsSuccessStatusCode);
             Assert.NotNull(result.ReasonPhrase);
             Assert.NotNull(result.RequestMessage);
-            Assert.False(result.StatusCode == default(HttpStatusCode));
+            Assert.False(result.StatusCode == default);
             Assert.NotNull(result.Version);
             Assert.Equal("octocat", result.Content.Login);
             Assert.False(string.IsNullOrEmpty(result.Content.AvatarUrl));
@@ -362,7 +362,7 @@ public async Task HitTheGitHubUserApiAsObservableApiResponse()
             Assert.True(result.IsSuccessStatusCode);
             Assert.NotNull(result.ReasonPhrase);
             Assert.NotNull(result.RequestMessage);
-            Assert.False(result.StatusCode == default(HttpStatusCode));
+            Assert.False(result.StatusCode == default);
             Assert.NotNull(result.Version);
             Assert.Equal("octocat", result.Content.Login);
             Assert.False(string.IsNullOrEmpty(result.Content.AvatarUrl));