Fix primitive serialization #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hive handles primitive types using the base Hadoop writable rather than its own during joins, which means that in order to use the proper DoubleWritable class from Hive you have to actually return an object of the appropriate type in JsonSerDe.serializeField instead of a primitive.
rcongiu
requested changes
Apr 3, 2017
| @@ -302,22 +302,22 @@ public Object serializeField(Object obj, | |||
| Boolean.FALSE; | |||
| break; | |||
| case BYTE: | |||
| result = ((ByteObjectInspector)poi).get(obj); | |||
| result = Byte.valueOf(((ByteObjectInspector)poi).get(obj)); | |||
| break; | |||
There was a problem hiding this comment.
Since result is an object, not a primitive, Java autoboxing takes care of that automatically.
See http://docs.oracle.com/javase/tutorial/java/data/autoboxing.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt #2.
Hive handles primitive types using the base Hadoop writable rather than
its own during joins, which means that in order to use the proper
DoubleWritable class from Hive you have to actually return an object of
the appropriate type in JsonSerDe.serializeField instead of a primitive.