Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ISIS version update #17

Merged
merged 16 commits into from
Jul 11, 2024
Merged

Fix for ISIS version update #17

merged 16 commits into from
Jul 11, 2024

Conversation

rbeyer
Copy link
Owner

@rbeyer rbeyer commented Jul 10, 2024

Primarily, users will see that the new style of ISIS version file ($ISISROOT/isis_version.txt) is now properly auto-incorporated in kalasiris's version.py module.

Lots of updates to the build machinery and GitHub workflows also happened.

How Has This Been Tested?

  • make lint
  • make docs
  • make test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the pvl project uses.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.21%. Comparing base (ffca607) to head (8246e88).

Files Patch % Lines
kalasiris/version.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   92.60%   95.21%   +2.61%     
==========================================
  Files          12       12              
  Lines         487      481       -6     
==========================================
+ Hits          451      458       +7     
+ Misses         36       23      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeyer rbeyer merged commit 6e3d361 into main Jul 11, 2024
5 of 6 checks passed
@rbeyer rbeyer deleted the isis-version branch July 11, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant