Use (L)MDB backend instead of HDB #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenLDAP 2.5.x has deprecated and removed support for the HDB backend, which makes the tests fail. This commit changes the backend to MDB, which is the recommended one now. Closes rbarrois#7 Signed-off-by: Sergio Durigan Junior <[email protected]>
sergiodj
force-pushed
the
move-from-hdb-to-mdb-openldap-2.5
branch
from
09a9754
to
42baf3b
Compare
|
Closes #7 |
|
This seems to fail on a local setup with openldap-2.4; have you been able to run the tests on your end? Output: |
Hm, indeed, I can confirm the failure if I run the test with OpenLDAP It's not immediately clear to me why this is failing and how to fix |
|
Thanks for the quick feedback! I'll try to setup some automated CI on the package to detect that sooner — and I'll look into the lack of meaningful details here, likely related to not properly propagating the |
|
Ah, awesome, thank you very much! I'll keep you posted if/when I find |
|
Hi. The root cause appears to be ITS#9531. It's already fixed in the current OpenLDAP releases (2.4.59 and 2.5.5). The tests succeed for me with the 2.5.5 package from Debian experimental and @sergiodj's patch. A local build based on current Debian unstable (2.4.57) with the ITS#9531 patch applied also works for me. Do you need me to backport the fix to Debian testing (bullseye) and/or stable (buster)? The patch applies cleanly, but I would have to justify the need for it to the release managers. |
rtandy
reviewed
Jun 30, 2021
| @@ -144,8 +144,8 @@ def quote(base, *args): | |||
| yield quote('TLSCertificateFile %s', self._tls_certificate_path) | |||
| yield quote('TLSCertificateKeyFile %s', self._tls_key_path) | |||
|
|
|||
| yield quote('moduleload back_hdb') | |||
| yield quote('database hdb') | |||
| yield quote('moduleload back_mdb') | |||
There was a problem hiding this comment.
Just wondering whether mapsize should also be set when using this backend. The default is capacity is 10 MiB (source).
Ah, thanks a lot for checking this, Ryan!
I don't know if you will be able to justify backporting this patch to |
|
Oh, thanks for the analysis, that's quite helpful! I'll look into this on two sides:
|
|
Hello, I am having the same issue, using volatildap with OpenLdap 2.5. As of now, this PR solves issues I am facing. Is there any additional check to be made concerning this PR ? Thanks, |
|
hi all, a friendly bump :) is there anything we can do to help? cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenLDAP 2.5.x has deprecated and removed support for the HDB backend,
which makes the tests fail. This commit changes the backend to MDB,
which is the recommended one now.