-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multi-label support #298
base: master
Are you sure you want to change the base?
add multi-label support #298
Conversation
I verified the change works with the blow code example:
|
@Yard1 can you help take a look when you get a chance? thanks! |
@@ -118,12 +118,12 @@ def convert_to_series(data: Any) -> pd.Series: | |||
@classmethod | |||
def get_column( | |||
cls, data: pd.DataFrame, column: Any | |||
) -> Tuple[pd.Series, Optional[str]]: | |||
) -> Tuple[pd.Series, Optional[Union[str, List]]]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we open up a separate get_columns(...)
instead of overloading this method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! cc @krfricke
Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Hi @Yard1 may I ask how to fix the lint test? Seems it still blocks the merge. Thank you! |
Can you run the ./format.sh script in the root of the repo? |
@louis-huang can you please run the above test please? |
Hi I added support to allow label as a list. So we can support reading data with multiple labels. This can then solve #286.
I verified new unit tests pass. Also test_matrix.py all pass with my local set up.
I verified locally by training a xgboost model with parquet data format, it works well. So far it should work well for parquet data format. Thank you!