Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check for the resolvability of dependencies version requirements #5

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Add a check for the resolvability of dependencies version requirements #5

wants to merge 42 commits into from

Conversation

melis-m
Copy link
Contributor

@melis-m melis-m commented Sep 3, 2019

No description provided.

@melis-m
Start revamp, atm only take npf(s) and unwraps them
713a739
@melis-m
Add log functions (from nbuild + qlog)
ea2baec
@melis-m
Remove Kind enum
22be1a1
@melis-m
Add tarball/npf wrap function, no updates of the manifest.toml yet
388406f
@melis-m
Remove args.{output,backup}, as they're not used yet
fdb3be8
@melis-m
Add function to refresh date of manifest wrap_date
8c5ff82
@melis-m
Add log to data.tar.gz creation and manifest.toml
4e39c71
@melis-m
Add options to args to choose from fix/edit/diff
230cd2f
@melis-m
Add .gitignore
a90ad70
@melis-m
Add .gitignore and definition of core.pushd
f2adf6e
@melis-m
Add basis for checks
8409633
@melis-m
Add executable checks on shlibs/binaries
0c0740c
@melis-m
Merge branch 'master' of github.com:raven-os/npf-checker into checks
9ba0e49
@melis-m
npf-checker now only takes one .npf
02c7e30
@melis-m
Add base class for checks modifying manifest.toml
d9d7e42
@melis-m
Fix utils.ask_yne default (when pressing enter directly)
0c4c80f
@melis-m
Add some log.push and use of colored_path in tar creation logs
3fdc2d5
@melis-m
Reintroduce pkg to check_package, and to checks with manifest.toml
0599448
@melis-m
Add checks on manifest.toml's description
b8fe5f7
@melis-m
Remove self.manifest{,path} from CheckWithManifest, now use self.pkg
d82214b
@melis-m
add correct caps formatting to default option to utils.ask_yne
fb7bff4
@melis-m
Add check for resolvability of version reqs of deps
f2f3c47
@melis-m
Add log when running DescCheck's run function
9624071
@melis-m
Add spacing in the sentences of utils.ask_yn{,e}
6444c74
@melis-m
Fix pkg.show_manifest, version is now displayed properly
f3cad7d
@melis-m
Change version_reqs_solv.fix to propose the highest version when pkg …
3ea5ee2 
…exists
@melis-m
Add rewrite of the pkg manifest after auto fix
e4480ea
@melis-m
Add /{,s}bin/ and /lib{,32,64}/ and /usr/lib/ to Exec Checks
a87a832
@melis-m
Add help section to --action argument
75791b3
@melis-m
Merge branch 'master' of github.com:raven-os/npf-checker into checks
58afa1d
@melis-m melis-m requested a review from Arignir September 3, 2019 11:43
Arignir
Arignir requested changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@Arignir Arignir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dislike the way you're handling this fix a lot: hard-coding a Raven-OS URL means the check will always fail for user-maintained repositories, which is not great.

Instead, having a config file with all the repositories listed (and their URL), in order of priority (remember repository priorities is going to be a thing pretty soon) would be well more resilient.

Arignir
Arignir requested changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@Arignir Arignir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example config.toml is necessary, including explanations in the README on how to configure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arignir Arignir Awaiting requested review from Arignir

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melis-m @Arignir