Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Cython 3 and pyarrow 13.0.0 #60

Merged
merged 12 commits into from
Oct 2, 2023
Merged

Upgrade to Cython 3 and pyarrow 13.0.0 #60

merged 12 commits into from
Oct 2, 2023

Conversation

sjperkins
Copy link
Member

@sjperkins sjperkins commented Sep 28, 2023

@sjperkins
Copy link
Member Author

@orliac just a heads up that I'm changing the C++ ABI from GLIBCXX_USE_CXX11_ABI=0 to GLIBCXX_USE_CXX11_ABI=1 in this PR. I know you changed your SPAC build to use the older ABI. Previous discussion here:

I would've preferred to continue with the older ABI and there isn't a problem with the wheels built with it. However, one difficulty is that pyarrow 13.0.0 releases both manylinux2014 (old ABI) and manylinux_2_28 (new ABI) wheels, and pip prefers to install the newer one by default, causing symbol incompatibilities with a manylinux2014 arcae wheel.

My intention here is to bite the bullet and configure arcae to build manylinux_2_28 only. This should be fine as pip >= 20.3 supports manylinux_x_y tags and was released in Nov 30 2020.

However, perhaps there's another way around the above issue? Let me know if you can see something I can't!

@sjperkins sjperkins temporarily deployed to release-test September 29, 2023 13:39 — with GitHub Actions Inactive
@sjperkins sjperkins temporarily deployed to release-test September 29, 2023 13:47 — with GitHub Actions Inactive
@sjperkins sjperkins temporarily deployed to release-test September 29, 2023 13:53 — with GitHub Actions Inactive
@sjperkins
Copy link
Member Author

I'm intending to merge this PR soon.

@orliac
Copy link

orliac commented Oct 2, 2023

Hi @sjperkins,
Thanks for the update. Once you've merged I will update my Spack stack accordingly and let you know about the outcome. But the move makes sense to me.

@sjperkins
Copy link
Member Author

Thanks, also looks like Centos 7, on which manylinux2014 is based, will reach EOL in 9 months:

Similar to how PEP 571 and PEP 513 drew allowed shared libraries and their symbol versions from CentOS 5.11 and CentOS 6, respectively, a manylinux2014 platform tag will draw its libraries and symbol versions from CentOS 7, which will reach end-of-life on June 30th, 2024. [1]

@sjperkins sjperkins merged commit a69f071 into main Oct 2, 2023
7 checks passed
@sjperkins sjperkins deleted the pyarrow-13.0.0 branch October 2, 2023 09:06
@sjperkins sjperkins added this to the 0.2.0 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update build to use pyarrow 13.0.0 and Cython 3.0 Support manylinux_2_28 builds
2 participants