feat: add variable for setting the cpu_credits parameter in launch template #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ool launch template also updates existing README files
AbrohamLincoln
changed the title
|
Thanks for the contribution. We've looked though some documentation and have concerns about specifying a default value as the aws-set default value varies as it's based on instance type - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template#credit-specification We don't want to change the default value of a T3 instance, for example, without the user intentionally specifying that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updates existing README files