Enhance manufacturers table filtering #1037

[joshuadkitenge]

Description

• remove optional filter in manufacturer address in catalogue items table

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage
• {more steps here}

Agile board tracking

closes #1037

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.19%. Comparing base (fbf54d4) to head (bd86584).

Additional details and impacted files

@@            Coverage Diff            @@
##           develop    #1134    +/-   ##
=========================================
  Coverage    99.19%   99.19%            
=========================================
  Files           82       82            
  Lines        17058    17080    +22     
  Branches      2844     2050   -794     
=========================================
+ Hits         16920    16942    +22     
- Misses         134      137     +3     
+ Partials         4        1     -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[asuresh-code]

LGTM, just a few minor comments.

[asuresh-code]

Suggested change

	Header: TableHeaderOverflowTip,
	accessorFn: (row) => row.name,
	id: 'name',
	filterVariant: COLUMN_FILTER_VARIANTS.string,
	filterFn: COLUMN_FILTER_FUNCTIONS.string,
	columnFilterModeOptions: COLUMN_FILTER_MODE_OPTIONS.string,
	size: 400,
	Cell: ({ row }) =>
	row.original.name && (
	Header: TableHeaderOverflowTip,
	accessorFn: (row) => row.name,
	id: 'name',
	filterVariant: COLUMN_FILTER_VARIANTS.string,
	filterFn: COLUMN_FILTER_FUNCTIONS.string,
	columnFilterModeOptions: COLUMN_FILTER_MODE_OPTIONS.string,
	size: 400,
	Cell: ({ row }) =>
	(

name is a mandatory field so the conditional operator is not needed

[asuresh-code]

In the Modified Time column, the conditional expression row.original.modified_time && is not needed, as you pointed out in the SystemsTableView PR