Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance system table view filtering #1129 #1131

Conversation

joshuadkitenge
Copy link
Collaborator

@joshuadkitenge joshuadkitenge commented Nov 20, 2024

Description

Add string and datatime filter options

  • remove to unnecessary cell definition
  • remove unnecessary ternary

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

closes #1129

- remove to unnessary cell definition
- remove unnessary ternary
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.19%. Comparing base (fbf54d4) to head (c3fc2a1).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1131   +/-   ##
========================================
  Coverage    99.19%   99.19%           
========================================
  Files           82       82           
  Lines        17058    17060    +2     
  Branches      2844     2842    -2     
========================================
+ Hits         16920    16922    +2     
  Misses         134      134           
  Partials         4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@joshuadkitenge joshuadkitenge marked this pull request as ready for review November 20, 2024 16:33
Copy link
Contributor

@asuresh-code asuresh-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Also, I had a question whilst testing this PR in the item dialog; the user data entered into dialogs do not persist if the page refreshes, so they end up losing it. Is this an issue that should eventually be addressed, or is it not really a problem?

@joshuadkitenge
Copy link
Collaborator Author

The dialogs on this website are not designed to retain their state after being closed or when the page is refreshed.

@joshuadkitenge joshuadkitenge merged commit da93071 into develop Nov 21, 2024
6 checks passed
@joshuadkitenge joshuadkitenge deleted the enhancement/enhancement-system-table-view-filtering-#1129 branch November 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Systems table view filtering
2 participants