Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery view #1081 #1100

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from
Draft

Gallery view #1081 #1100

wants to merge 13 commits into from

Conversation

joshuadkitenge
Copy link
Collaborator

@joshuadkitenge joshuadkitenge commented Nov 1, 2024

Description

see #1081 and #1084

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • Check corrupted images

Agile board tracking

closes #1081, closes #1084

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 99.17808% with 3 lines in your changes missing coverage. Please review.

Project coverage is 99.20%. Comparing base (8423d0f) to head (c704a36).
Report is 13 commits behind head on develop.

Files with missing lines Patch % Lines
src/common/images/imageGallery.component.tsx 99.06% 2 Missing ⚠️
src/mocks/handlers.ts 98.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1100      +/-   ##
===========================================
+ Coverage    99.15%   99.20%   +0.04%     
===========================================
  Files           82       85       +3     
  Lines        16922    17411     +489     
  Branches      2057     2090      +33     
===========================================
+ Hits         16779    17272     +493     
+ Misses         142      138       -4     
  Partials         1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Base automatically changed from upload-images-#1062 to develop November 4, 2024 09:49
src/mocks/image.json Outdated Show resolved Hide resolved
src/mocks/handlers.ts Outdated Show resolved Hide resolved
src/common/images/imageGallery.component.tsx Show resolved Hide resolved
- remove max height in thumbnail
- one image should have a max length of 50%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle corrupted images or thumbnails Implement a Gallery View for displaying images.
2 participants