test: standardize to 8 character commit SHA1 in assert_contributor_names #314
+1,508
−1,412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script which provides a CLI similar to
rails test
, but runs the suite with a version ofassert_contributor_names
which:assert_contributor_names
call with the unambiguous SHA1 prefix.assert_contributor_names
calls which pass with an 8 character long SHA1.Example output running
bin/lengthen-sha1
compared tobin/rails test
. Note the difference in number of assertions:bin/lengthen-sha1
won't rewrite a SHA1 in anassert_contributor_names
which does not pass with the original expectation.This PR includes the modifications form the above example test run in: