Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple GUI launch test to CIs #57

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

andreped
Copy link
Member

@andreped andreped commented Sep 29, 2023

[no ci]

This only testes that the generated exectuable launches without any errors, which may be relevant to test when changing dependencies and versions before merging PRs to the master branch.

Also changed the --log-level of the PyInstaller runs to INFO again, as using the DEBUG flag should not be the default, unless something goes wrong. Using the DEBUG flag should likely only be performed locally, as it greatly degrades the install runtime.

@andreped
Copy link
Member Author

Might be that on some operating systems that the error raised by the Raidionics software is not caught by the global process in the Action. I guess you could run a test to see if it works as intended (e.g., actually captures a known ValueError and stops the CI workflow).

@dbouget dbouget merged commit c4348c6 into raidionics:master Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants