Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pre-commit check commitizen #8

Merged
merged 1 commit into from
Feb 27, 2024
Merged

feat: add pre-commit check commitizen #8

merged 1 commit into from
Feb 27, 2024

Conversation

CodeChenL
Copy link
Contributor

@CodeChenL CodeChenL commented Feb 26, 2024 •
edited by RadxaYuntian
Loading

@CodeChenL
Copy link
Contributor Author

@RadxaYuntian

@RadxaYuntian
Copy link
Member

你这没有修复#4对应的脚本啊

RadxaYuntian
RadxaYuntian requested changes Feb 26, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated
Comment on lines 46 to 48
stages:
- post-commit
- push
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该是post-checkout stage：https://pre-commit.com/#post-checkout

RadxaYuntian
RadxaYuntian requested changes Feb 26, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@RadxaYuntian
Copy link
Member

另外我才注意到这个是radxa-docs/pre-commit-hooks。这个hook其实是要放到documentation里面的，这个仓库只涉及我们自定义的hook。
现在这边加了弄好了直接复制到那边去

@CodeChenL
Copy link
Contributor Author

另外我才注意到这个是radxa-docs/pre-commit-hooks。这个hook其实是要放到documentation里面的，这个仓库只涉及我们自定义的hook。 现在这边加了弄好了直接复制到那边去

我想着是先加在这个仓库实验，也没坏处

@RadxaYuntian
Copy link
Member

是的，因为以后也要加到别的仓库里面去

RadxaYuntian
RadxaYuntian reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commitizen-branch在documentation那边测试过了么

@CodeChenL
Copy link
Contributor Author

CodeChenL commented Feb 26, 2024 •
edited
Loading

commitizen-branch在documentation那边测试过了么

提交和push没问题

@RadxaYuntian
Copy link
Member

我的意思是pre-commit run --hook-stage push --from-ref FROM_REF --to-ref TO_REF能检查历史commit消息么？

@RadxaYuntian
Copy link
Member

这边合并了documentation那边会以这边的实现为参考进行对比

@CodeChenL
Copy link
Contributor Author

使用自定义正则解决#4

RadxaYuntian
RadxaYuntian requested changes Feb 27, 2024
View reviewed changes
.cz.toml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

别把所有的东西都放进来，只把我们自己修改过的部分留着。其他保持默认的就不要放进来

RadxaYuntian
RadxaYuntian requested changes Feb 27, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
RadxaYuntian
RadxaYuntian reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@RadxaYuntian RadxaYuntian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash

@RadxaYuntian RadxaYuntian merged commit 81be737 into radxa-docs:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadxaYuntian RadxaYuntian RadxaYuntian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

使用commitizen检查commit格式 commit信息禁止出现update
2 participants
@CodeChenL @RadxaYuntian