Fix semicolon issue for formulas #26
Conversation
| @@ -1469,7 +1469,7 @@ private List<DynamicRow> GetSortedSheetData(Worksheet sheet) | |||
| /// <param name="input">Input string to process</param> | |||
| /// <returns>Escaped string</returns> | |||
| /// <remarks>Note: The XML specs allow characters up to the character value of 0x10FFFF. However, the C# char range is only up to 0xFFFF. NanoXLSX will neglect all values above this level in the sanitizing check. Illegal characters like 0x1 will be replaced with a white space (0x20)</remarks> | |||
| public static string EscapeXmlChars(string input) | |||
| public static string EscapeXmlChars(string input, bool sanitizeSemicolon = false) | |||
There was a problem hiding this comment.
Please add the parameter as documentation entry (between line 1469 and 1470)
| @@ -576,6 +577,13 @@ private static void Demo13() | |||
| wb2.Save(); // Save the workbook | |||
| } | |||
|
|
|||
| private static void Demo14() | |||
There was a problem hiding this comment.
Please remove the demo. The feature is a little bit too obscure to designate it as a single demo.
Testing of the feature will be taken into account as a one or some testcase(s) in the new major version which is currently in the dev branch under development.
Alternatively:
Add the line 583 in another demo, where the usage of formulas is shown. Add an appropriate comment to the line in this case (describe what happens with the formula text)
|
Sorry to respond again, but it looks like the solution is not robust. I stumbled into issues when implementing the feature in the dev branch. <c r="B1" t="str">
<f>CONCATENATE(A1,";",A2)</f>
<v>a;b</v>
</c>However, a general sanitizing would lead to: <c r="B1" t="str">
<f>CONCATENATE(A1,",",A2)</f>
</c>So, we cannot go whith this solution (PR cannot be merged, sorry). Currently, there is no good solution for this. We have probably to look directly into the AddCellFormula / AddNextCellFormula functions. However, a general replacement of |
I found that semicolons in formulas were replaced with '|'.
I added it as an illegal character, and replaced the semicolon with a comma where you escape other illegal characters.
This seems to be what happens when saving something from google docs, and it seems to have worked. See Demo14.
I added an optional boolean parameter to the method, as I don't have the full overview of the other use-cases of the method.