Add a test for segfault when processing module dependencies #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to create tests for the solver Signed-off-by: Rafael Fonseca <[email protected]>
To create a new test case, create a subdirectory in tests/ containing:
input : text file with input solvables (one per line)
expected : text file with expected output (one per line)
packages.repo : libsolv repo description (optional)
lookaside.repo: libsolv repo description (optional)
modules.yaml : modulemd module metadata (optional)
and an ADD_TEST(test_name, test_dir) line to tests.c.
A simple test case 'ursine' is included to exemplify the above procedure
Signed-off-by: Rafael Fonseca <[email protected]>
Signed-off-by: Rafael Fonseca <[email protected]>
Signed-off-by: Rafael Fonseca <[email protected]>
This test is based on issue fedora-modularity#33. It currently fails and PR fedora-modularity#35 should fix it. Signed-off-by: Rafael Fonseca <[email protected]>
This test exercises "empty" module stream expansion. Signed-off-by: Rafael Fonseca <[email protected]>
r4f4
reviewed
Oct 3, 2018
| requires: | ||
| platform: [f29] | ||
| m2: [master] | ||
| - requires: |
There was a problem hiding this comment.
Removing this line makes the seg fault go away. For some reason it causes fus to never leave the recursive function _gather_alternatives.
There was a problem hiding this comment.
I guess because it still tries to do something with buildrequires which are empty...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another test which makes fus segfault. The culprit are the dependencies in
m1-develmodule. I'm not sure if the modulemd is actually correct and meaningful, so maybe the correct solution would be to report an error. However it should not crash.