Indicate that absolute URLs are needed for search #2340
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting started suggests to start with
usethis::use_pkgdown()
. This sets_pkgdown.yml
toI thought
~
was the recommended way to set the url: if I change domain name, I don't have to edit this file. I recently discovered however that for a website likeorg.github.io/my_package
search results will link to the incorrect page atorg.github.io
, ignoringmy_package
. This issue was reported in #1945, with the suggested fix to provide the domain name inurl
.Indeed, this is indicated in Getting started, but I think it might be good to indicate search is one of the functions that requires absolute URLs.
The current example in the documentation is:
Perhaps it is more useful to provide an non-root domain example, which is typical for users who host their pkgdown site from GitHub Pages (e.g. https://my_org.github.io/my_package). This could then also provide guidance on whether to use an ending slash or not: