Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_tidy_github_actions() #1776

Merged
merged 3 commits into from
Sep 27, 2021
Merged

use_tidy_github_actions() #1776

merged 3 commits into from
Sep 27, 2021

Conversation

hadley
Copy link
Member

@hadley hadley commented Sep 21, 2021

No description provided.

@hadley hadley requested a review from maelle September 21, 2021 18:06
@hadley
Copy link
Member Author

hadley commented Sep 21, 2021

@maelle could you please make sure I haven't messed up anything in the pkgdown action?

@hadley
Copy link
Member Author

hadley commented Sep 21, 2021

Should fix #1552

Copy link
Collaborator

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (although I will be more confident after the next PR after this has been merged). Just a small question.

- main
- master
branches: [main, master]
tags: ['*']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? I think we want the site to be re-built when we push a tag (which indicates a release)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok!

@hadley hadley merged commit b5b4bd4 into master Sep 27, 2021
@hadley hadley deleted the actions-update branch September 27, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants