Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added about() function #138

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

claretgrace0801
Copy link
Contributor

For solving #51, have added an about function to qutip_qip.
This pull request is a continuation of the PR: qutip/qutip#1870 and is dependent on it (this PR won't work without merging the mentioned qutip PR. That qutip PR does not affect any existing functionality of qutip)

Changelog
qutip_qip.about() calls qutip.about("qutip_qip"), which show info about qutip_qip

Refer to qutip/qutip#1870 for more details.

Copy link
Member

@BoxiLi BoxiLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It would be nice if we can rename the function that returns titles and lines as a private function _about, and give it to the entry point. Then we can define a about that just call qutip.about().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants