Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Qiskit Ecosystem theme #1225

Closed

Conversation

frankharkins
Copy link
Contributor

@frankharkins frankharkins commented Aug 22, 2023

Summary

Updates to the new documentation theme. This is a draft PR to test docs build times.

  • Total file size increased by ~505% (5mb -> 27mb)
  • Build time increase by ~1512% (58s -> 877s)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5941753047

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.856%

Totals Coverage Status
Change from base Build 5926831729: 0.0%
Covered Lines: 9810
Relevant Lines: 11166

💛 - Coveralls

@mrossinek
Copy link
Member

  • Build time increase by ~1512% (58s -> 877s)

Just curious: are there any plans of addressing this? That build time is a bit excessive.

@Eric-Arellano
Copy link
Contributor

Just curious: are there any plans of addressing this? That build time is a bit excessive.

Yeah, this is still a draft because we first wanted to see how bad the hit was. For some repos, it's faster to use the new theme! For others like Qiskit or this repo, it's much slower naively.

We have a few techniques to work around this. Only haven't had time yet to implement it. We have an intern starting soon who we're hoping can help switch projects over :)

@mrossinek
Copy link
Member

@frankharkins Given qiskit-community/qiskit-nature-pyscf#44, can we expect this PR to move forward, too?
What do the timings look like with the latest version of the theme?

@Eric-Arellano
Copy link
Contributor

@mrossinek, yes, @arnaucasau is a new intern at IBM and his first main project is to switch all the Ecosystem projects to the new theme 🙌 He's triaging if switching results in slow downs. When it does slow down, there are things we can do like reorganizing API docs to speed it up. He'll be helping projects out with that.

@frankharkins frankharkins deleted the fh-switch-themes branch September 29, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants