Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 support #1223

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Aug 14, 2023

Summary

CI nightly has been failing now for a while under 3.7 around mypy and rustworkx - the latter got updated to 0.13.1 and the constraint we had no longer worked. While I could have amended constraint, as Qiskit has now dropped support for 3.7 this drops it from Nature too, rendering the rustworkx constraint mute (which I removed), and means CI should now pass.

Details and comments

A reno notes the upgrade needed for the user.

  • Once this passes we should amend the CI branch rules accordingly.

This should also allow #1222 to go forwards once merged.

I had meant to look for sys version checks and forgot (now done) - CI flagged a line no longer being tested and it turns out it was a version check. So I just removed this and what was needed for 3.7. This was protocols.py - I mused over changing the eigenstate result not to be a string - but there are other places where this could be done so Iet it be. I had noticed as the string was missing a period - which I fixed; I let that be the extent of the change otherwise.

@coveralls
Copy link

coveralls commented Aug 14, 2023

Pull Request Test Coverage Report for Build 5858396532

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 87.874%

Totals Coverage Status
Change from base Build 5445189731: 0.5%
Covered Lines: 9812
Relevant Lines: 11166

💛 - Coveralls

Copy link
Member

@mrossinek mrossinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, Steve! 👍

@mrossinek mrossinek merged commit e9e2662 into qiskit-community:main Aug 21, 2023
15 checks passed
@woodsp-ibm woodsp-ibm deleted the drop_3.7 branch August 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants