Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent downstream breakages by using compatible release version clauses (~= instead of >=) #518

Closed
wants to merge 5 commits into from
Closed

fix: prevent downstream breakages by using compatible release version clauses (~= instead of >=) #518

wants to merge 5 commits into from

Commits on Apr 29, 2024

  1. fix: hardcode version matching clause: typer==0.12.3 

    Safety CLI depends on _underscore methods defined in typer which are not guaranteed to be stable, even across bugfix version changes. Locking typer to version 0.12.3, while inconvenient, is unfortunately necessary to ensure that refactorings in typer do not negatively impact our users. Helps fix pyupio#511
    @jeff-at-tamer-dot-codes
    jeff-at-tamer-dot-codes committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    7af043a View commit details
    Browse the repository at this point in the history

  2. fix: hardcode typer==0.12.3 in test_requirements.txt also. 

    helps fix pyupio#511
    @jeff-at-tamer-dot-codes
    jeff-at-tamer-dot-codes committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    27af28c View commit details
    Browse the repository at this point in the history

  3. padding all version clause comparison operators with spaces. 

    #readability #noop
    @jeff-at-tamer-dot-codes
    jeff-at-tamer-dot-codes committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    5fd247e View commit details
    Browse the repository at this point in the history

  4. sorting all version schemes lexicographically. 

    #readability #noop
    @jeff-at-tamer-dot-codes
    jeff-at-tamer-dot-codes committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    cdaeb93 View commit details
    Browse the repository at this point in the history

  5. switching to use compatible release version clauses ~= wherever pos… 

    …sible.

Note: this commit is NOT a noop. Switching to ~= will prevent unintentionally breaking our users due to a major version change out of our control upstream. For packages still in beta (i.e. packages whose major versions equal zero), we use the latest "major.minor.bugfix" as the version identifier; otherwise we use "major.minor". Tested manually. I believe this PR fixes pyupio#511 in spirit.
    @jeff-at-tamer-dot-codes
    jeff-at-tamer-dot-codes committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    63d7289 View commit details
    Browse the repository at this point in the history