Reduce scaleup build proposal excessive logging #2576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66277574 |
damianr99
pushed a commit
to damianr99/torchrec
that referenced
this pull request
Nov 21, 2024
Summary: D65774286 added additional logging to highlight when EmbeddingOffloadScaleupProposer searches only the cheapest of multiple sharding options provided. However it dumps the entire sharding option, rather than just the table name. Update to just print the table name. Differential Revision: D66277574
damianr99
pushed a commit
to damianr99/torchrec
that referenced
this pull request
Nov 21, 2024
Summary: D65774286 added additional logging to highlight when EmbeddingOffloadScaleupProposer searches only the cheapest of multiple sharding options provided. However it dumps the entire sharding option, rather than just the table name. Update to just print the table name. Differential Revision: D66277574
damianr99
force-pushed
the
export-D66277574
branch
from
2efa6e5
to
8e91f6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66277574 |
damianr99
pushed a commit
to damianr99/torchrec
that referenced
this pull request
Nov 21, 2024
Summary: D65774286 added additional logging to highlight when EmbeddingOffloadScaleupProposer searches only the cheapest of multiple sharding options provided. However it dumps the entire sharding option, rather than just the table name. Update to just print the table name. Reviewed By: keyan Differential Revision: D66277574
damianr99
pushed a commit
to damianr99/torchrec
that referenced
this pull request
Nov 21, 2024
Summary: D65774286 added additional logging to highlight when EmbeddingOffloadScaleupProposer searches only the cheapest of multiple sharding options provided. However it dumps the entire sharding option, rather than just the table name. Update to just print the table name. Reviewed By: keyan Differential Revision: D66277574
damianr99
force-pushed
the
export-D66277574
branch
from
8e91f6e
to
9a52c7c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66277574 |
Summary: D65774286 added additional logging to highlight when EmbeddingOffloadScaleupProposer searches only the cheapest of multiple sharding options provided. However it dumps the entire sharding option, rather than just the table name. Update to just print the table name. Reviewed By: keyan Differential Revision: D66277574
damianr99
force-pushed
the
export-D66277574
branch
from
9a52c7c
to
2ed3b3c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66277574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D65774286 added additional logging to highlight when
EmbeddingOffloadScaleupProposer searches only the cheapest of multiple
sharding options provided. However it dumps the entire sharding
option, rather than just the table name. Update to just print the
table name.
Differential Revision: D66277574