Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 core machine #46

Merged
merged 19 commits into from
Apr 6, 2024
Merged

32 core machine #46

merged 19 commits into from
Apr 6, 2024

Conversation

metascroy
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 5, 2024
@mikekgfb
Copy link
Contributor

mikekgfb commented Apr 5, 2024

@byjlw @dbort are we missing a part of executorch based on this error?

    export_model_et(model, device, args.output_pte_path, args)
  File "/home/runner/work/llama-fast/llama-fast/export_et.py", line 145, in export_model
    export_program = edge_manager.to_executorch(
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/llama-fast/llama-fast/executorch/exir/program/_program.py", line 871, in to_executorch
    return ExecutorchProgramManager(
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/llama-fast/llama-fast/executorch/exir/program/_program.py", line 925, in __init__
    self._pte_data: Cord = _serialize_pte_binary(
                           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/llama-fast/llama-fast/executorch/exir/_serialize/_program.py", line 424, in serialize_pte_binary
    result: _FlatbufferResult = _program_json_to_flatbuffer(
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/llama-fast/llama-fast/executorch/exir/_serialize/_flatbuffer.py", line 283, in _program_json_to_flatbuffer
    schema_info = _prepare_schema(
                  ^^^^^^^^^^^^^^^^
  File "/home/runner/work/llama-fast/llama-fast/executorch/exir/_serialize/_flatbuffer.py", line 156, in _prepare_schema
    schemas = _ResourceFiles([program_schema] + deps)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/llama-fast/llama-fast/executorch/exir/_serialize/_flatbuffer.py", line 113, in __init__
    self._files[name] = importlib.resources.read_binary(__package__, name)
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py", line 25, in wrapper
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/importlib/resources/_legacy.py", line 52, in read_binary
    return (_common.files(package) / normalize_path(resource)).read_bytes()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/pathlib.py", line 1050, in read_bytes
    with self.open(mode='rb') as f:
         ^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/pathlib.py", line 1044, in open
    return io.open(self, mode, buffering, encoding, errors, newline)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/llama-fast/llama-fast/executorch/exir/_serialize/program.fbs'

@Jack-Khuu
Copy link
Contributor

Just as a sanity check: What does the file structure looks like when calling this?

/home/runner/work/llama-fast/llama-fast/executorch/exir/_serialize/program.fbs

Specifically, this looks like the program is looking for a file path instead of the module (Because Python gives local paths precedence)

@mikekgfb
Copy link
Contributor

mikekgfb commented Apr 5, 2024

File "/home/runner/work/llama-fast/llama-fast/executorch/exir/_serialize/_flatbuffer.py", line 113, in init
self._files[name] = importlib.resources.read_binary(package, name)

The caller for this is Executorch's executorch/exir/_serialize/_flatbuffer.py if I understand correctly?
Would that imply that ET is calling the wrong way?

File "/home/runner/work/llama-fast/llama-fast/executorch/exir/_serialize/_flatbuffer.py", line 113, in init
self._files[name] = importlib.resources.read_binary(package, name)

@metascroy metascroy merged commit 49c8f5f into main Apr 6, 2024
5 checks passed
@metascroy metascroy deleted the et-yml branch April 6, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants