Add Intel XPU device support to generate and serve #1361
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1361
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 4d16351 with merge base 2cf1a17 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @jenniew! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Is there a way to run at least a few simple tests on an xpu to avoid inadvertent breakage? |
For generate, run a simple test by |
| PYTORCH_NIGHTLY_VERSION=dev20241002 | ||
| if [[ -x "$(command -v xpu-smi)" ]]; | ||
| then | ||
| PYTORCH_NIGHTLY_VERSION=dev20241001 |
There was a problem hiding this comment.
Why does xpu need an older PYTORCH_NIGHTLY?
There was a problem hiding this comment.
when install torch==2.6.0.dev20241002 and torchvision==0.20.0.dev20241002+xpu, it will get error:
ERROR: Cannot install torch==2.6.0.dev20241002 and torchvision==0.20.0.dev20241002+xpu because these package versions have conflicting dependencies.
The conflict is caused by:
The user requested torch==2.6.0.dev20241002
torchvision 0.20.0.dev20241002+xpu depends on torch==2.6.0.dev20241001
So for xpu, I changed the torch nightly version to dev20241001
There was a problem hiding this comment.
Let me see if I can get you a fresher version on XPU, the torch/vision discrepancy shouldn't be a normal thing
| REQUIREMENTS_TO_INSTALL=( | ||
| torch=="2.6.0.${PYTORCH_NIGHTLY_VERSION}" | ||
| torchvision=="0.20.0.${VISION_NIGHTLY_VERSION}" | ||
| torchtune=="0.3.1" |
There was a problem hiding this comment.
Context on the varying tune version?
There was a problem hiding this comment.
On xpu nightly URL, it does not have nightly version of torchtune, so just install 0.3.1 release for xpu environment.
There was a problem hiding this comment.
Hmm we should add support for nightly, let me ping some torchtune folk
cc: @ebsmothers
|
Welcome to torchchat and thanks for adding @jenniew!! Super stoked to see that it didn't require much lift to get XPU set up. Added a few questions on the versioning difference. What device did you test on btw? Tagging a few folk who I'm trying to help taking a larger role |
|
@jenniew Also do you mind filling out the CLA? It'll allow you to contribute to Meta repos |
Yes, I just signed the CLA |
facebook-github-bot
added
the
CLA Signed
I tested on Intel Data Center GPU Max 1100. |
|
Just an update:
|
Add XPU device support exclude distributed mode, workflow, documentation.