Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Use <spec>_unbatched in VMAS #2593

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 20, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2593

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Cancelled Job, 15 Unrelated Failures

As of commit ed4493d with merge base a47b32c (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Nov 20, 2024
ghstack-source-id: cdb92a027c3ac446de8a4fce3f731d6e726cf0d0
Pull Request resolved: #2593
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
@vmoens vmoens added enhancement New feature or request Refactoring Refactoring of an existing feature Environments Adds or modifies an environment wrapper labels Nov 20, 2024
vmoens added a commit that referenced this pull request Nov 20, 2024
ghstack-source-id: cdb92a027c3ac446de8a4fce3f731d6e726cf0d0
Pull Request resolved: #2593
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 20, 2024
ghstack-source-id: a27cd96fe057352105bedc2ed8163a81f1f08148
Pull Request resolved: #2593
Copy link
Contributor

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! So the batched versions are built automatically?

@vmoens
Copy link
Contributor Author

vmoens commented Nov 20, 2024

yep I wrote a setter for them

[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 20, 2024
ghstack-source-id: 72210221e9a838f3a1cad3d64ca058fb68af5e63
Pull Request resolved: #2593
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 20, 2024
ghstack-source-id: 2190278de44ba59a3bc8d38398fddae9ecc42a84
Pull Request resolved: #2593
@vmoens vmoens merged commit ed4493d into gh/vmoens/45/base Nov 20, 2024
55 of 73 checks passed
vmoens added a commit that referenced this pull request Nov 20, 2024
ghstack-source-id: 2190278de44ba59a3bc8d38398fddae9ecc42a84
Pull Request resolved: #2593
@vmoens vmoens deleted the gh/vmoens/45/head branch November 20, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request Environments Adds or modifies an environment wrapper Refactoring Refactoring of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants