-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Use <spec>_unbatched in VMAS #2593
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2593
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Cancelled Job, 15 Unrelated FailuresAs of commit ed4493d with merge base a47b32c (): NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ghstack-source-id: cdb92a027c3ac446de8a4fce3f731d6e726cf0d0 Pull Request resolved: #2593
ghstack-source-id: cdb92a027c3ac446de8a4fce3f731d6e726cf0d0 Pull Request resolved: #2593
ghstack-source-id: a27cd96fe057352105bedc2ed8163a81f1f08148 Pull Request resolved: #2593
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! So the batched versions are built automatically?
yep I wrote a setter for them |
ghstack-source-id: 72210221e9a838f3a1cad3d64ca058fb68af5e63 Pull Request resolved: #2593
ghstack-source-id: 2190278de44ba59a3bc8d38398fddae9ecc42a84 Pull Request resolved: #2593
ghstack-source-id: 2190278de44ba59a3bc8d38398fddae9ecc42a84 Pull Request resolved: #2593
Stack from ghstack (oldest at bottom):
@matteobettini LMK if that works