Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix failing tests #2582

Merged
merged 15 commits into from
Nov 19, 2024
Merged

[BugFix] Fix failing tests #2582

merged 15 commits into from
Nov 19, 2024

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Nov 18, 2024

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2582

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 20 New Failures, 5 Unrelated Failures

As of commit ebbe72a with merge base 408cf7d (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vmoens added a commit that referenced this pull request Nov 18, 2024
ghstack-source-id: e05b0dc5435a83532c8cc3b980e0fbc51ffb142b
Pull Request resolved: #2582
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2024
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 18, 2024
ghstack-source-id: cacee5ae909f4b6109dd887d240a8956acc1bd38
Pull Request resolved: #2582
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 18, 2024
ghstack-source-id: 1c34b22fa4d7253ad318bd061da14a671be9a4d6
Pull Request resolved: #2582
@vmoens vmoens added the bug Something isn't working label Nov 19, 2024
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 230e436498c55ac7559c4648c5da9a75736c4c24
Pull Request resolved: #2582
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 57598167c45c5db5b1dd504c1b09891db7c70b05
Pull Request resolved: #2582
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 196d0416a94044ee299b7b7b39fd65fcbaf66c11
Pull Request resolved: #2582
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: 059c44397c8cdcfacff0c3a106d0586bd300264a
Pull Request resolved: #2582
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vmoens vmoens merged commit ebbe72a into gh/vmoens/43/base Nov 19, 2024
11 of 19 checks passed
vmoens added a commit that referenced this pull request Nov 19, 2024
ghstack-source-id: a43a2e3dbf76cd63c57ae00028df04b41a4e2f2b
Pull Request resolved: #2582
@vmoens vmoens deleted the gh/vmoens/43/head branch November 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants