[Feature] Make advantages compatible with Terminated, Truncated, Done #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/test_libs.py # torchrl/envs/gym_like.py
Co-authored-by: Skander Moalla <[email protected]>
Co-authored-by: Skander Moalla <[email protected]>
Co-authored-by: Skander Moalla <[email protected]>
|
Could you merge main? |
|
You should be able to do it |
|
no, I can't |
10 tasks
vmoens
added a commit
to hyerra/rl
that referenced
this pull request
Oct 10, 2023
…pytorch#1581) Co-authored-by: Skander Moalla <[email protected]> Co-authored-by: Matteo Bettini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually tested that everything was working without truncated key for bc compatibility.
Not sure if we should test that things work if terminated is missing in all losses as it's very redundant and the cost tests are already very long.
I didn't include the truncated -> done fallback in the docstrings, maybe we should but I don't want to overload them.
Depends on #1539