-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BC-Breaking] Fix model downloading in bento #3803
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3803
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit 16774fb with merge base 7f6209b (): NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D59061348 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a description that this is BC-breaking change (dl_kwargs
removed), so that it information can be found easily when crafting the release note?
Summary: Pull Request resolved: pytorch#3803 The model checkpoint path can not be created for Squim models. Use the latest download_asset method to fix it. Reviewed By: moto-meta Differential Revision: D59061348
This pull request was exported from Phabricator. Differential Revision: D59061348 |
Summary: Pull Request resolved: pytorch#3803 The model checkpoint path can not be created for Squim models. Use the latest download_asset method to fix it. Reviewed By: moto-meta Differential Revision: D59061348
This pull request was exported from Phabricator. Differential Revision: D59061348 |
@nateanl has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This pull request was exported from Phabricator. Differential Revision: D59061348 |
This is a BC-Breaking change (dl_kwargs removed).
Summary: The model checkpoint path can not be created for Squim models. Use the latest download_asset method to fix it.
Differential Revision: D59061348