-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up automation for updating pytype and pyright versions. #11491
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Before merging this, I will figure out why the CI is failing on this pull request, and test this in my fork.
Did you consider setting up a Dependabot configuration instead? That would be preferable since it means we can rely on a well-tested, widely used tool instead of having to write the script ourselves. |
We can't do that for pyright because of the unique way we pin pyright in pyproject.toml. Perhaps we could do a handrolled solution for pyright and do dependabot for everything else, though |
About dependabot, I'll repost this conversation: jakebailey/pyright-action#9 (comment) Renovate could possibly do it. Otherwise it looks like it might be possible to Contributing new ecosystems There's also the option of using https://pypi.org/project/pyright/ and updating our scripts to get the version from iirc, the sole reason the version is stored in |
You can pin pyright in a
|
I use renovate over at https://github.com/AlexWaygood/typeshed-stats and it works fine, though it's a bit of a pain to configure it correctly. I'd prefer dependabot if possible; @jakebailey's suggestion of reading the pyright version from a json file sounds great if it'll work with dependabot. |
For a more concrete example of how to do this in GHA: https://github.com/microsoft/TypeChat/blob/main/.github/workflows/ci.python.yml#L49 But if you find this too cumbersome, I feel like I should probably add something to the action that lets you give it a package.json to read. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think a solution that uses dependabot rather than a custom Python script would be simpler, easier to maintain, and less prone to bugs (since dependabot is widely used and well tested)
Yes if it can be solved by dependabot, nothing is better than that. |
fix: #11484