-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update minimum Python version to 3.9 in the configuration #137
Update minimum Python version to 3.9 in the configuration #137
Conversation
Thanks for the PR! There's some linting to fix. Please could you run: python -m pip install pre-commit
pre-commit run --all-files Or if you use uv, something like this: uvx pre-commit run --all-files And commit the changed file? |
Thank you for the feedback! |
IIUC the formatting changes are a direct result of no longer supporting 3.8, so I think it's fine to include them here. Separately, it looks like the pre-commit configuration could stand an update (which should be a separate PR :)) |
Thank you for pointing, I added this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! 🎃🍒
@hugovk perhaps, somebody has to enable the pre-commit.ci app for this repo, eh? |
Good idea, I sent a request via https://pre-commit.ci/ to enable this repo. @JacobCoffee, please can you accept it? |
@hugovk done |
Thanks! |
🍒Update minimum Python version to 3.9 in the configuration
Resolves #136